Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft is changing netcoreapp5.0 to net5.0 #3834

Closed
0x53A opened this issue Apr 24, 2020 · 12 comments
Closed

Microsoft is changing netcoreapp5.0 to net5.0 #3834

0x53A opened this issue Apr 24, 2020 · 12 comments

Comments

@0x53A
Copy link
Contributor

0x53A commented Apr 24, 2020

see

dotnet/runtime#35202

dotnet/runtime#35176

@TheAngryByrd
Copy link
Contributor

Just hit this.

@forki
Copy link
Member

forki commented May 25, 2020

So it's already changed?

@ngg
Copy link

ngg commented Jun 9, 2020

Yes, since .NET 5.0 Preview 3, the target has been renamed netcoreapp5.0 -> net5.0. Also there is a net5.0-windows target which also supports some windows specific extensions like WPF.

Probably only from .NET 6.0, but according to https://github.com/dotnet/designs/blob/master/accepted/2020/net5/net5.md and https://devblogs.microsoft.com/dotnet/announcing-net-5-preview-4-and-our-journey-to-one-net/ there will be more targets like net6.0-ios14.0 which targets iOS 14.0 or higher.

@forki
Copy link
Member

forki commented Jun 9, 2020

net5-win? or what's the exact moniker? @terrajobst

@ngg
Copy link

ngg commented Jun 9, 2020

https://github.com/dotnet/designs/blob/master/accepted/2020/net5/net5.md#what-about-net-10 says that net5 "Will work, but shouldn't be used" and only net5.0 should be used. I don't think the "windows" part can be shortened.

@terrajobst
Copy link

terrajobst commented Jun 10, 2020

Yep, “net5.0-windows” is the correct form. The short form “win” is from an earlier draft.

@seanamosw
Copy link
Contributor

seanamosw commented Jul 8, 2020

Using version 5.247.4 of paket, after doing a dotnet paket install, attempt to do a restore:

-> failed to parse line '      System.Reflection.Emit.ILGeneration (>= 4.7) - restriction: || (&& (== netcoreapp2.0) (>= netcoreapp5.0)) (&& (== netcoreapp2.0) (< netstandard1.1)) (&& (== netcoreapp2.0) (< netstandard2.0)) (&& (== netcoreapp2.0) (>= uap10.1)) (== netstandard2.0)' (invalid parameter 'netcoreapp5.0' after >= or < in '>= netcoreapp5.0)) (&& (== netcoreapp2.0) (< netstandard1.1)) (&& (== netcoreapp2.0) (< netstandard2.0)) (&& (== netcoreapp2.0) (>= uap10.1)) (== netstandard2.0)') (Could not parse 'framework: restriction: || (&& (== netcoreapp2.0) (>= netcoreapp5.0)) (&& (== netcoreapp2.0) (< netstandard1.1)) (&& (== netcoreapp2.0) (< netstandard2.0)) (&& (== netcoreapp2.0) (>= uap10.1)) (== netstandard2.0)' as key/value pairs.)
	-  invalid parameter 'netcoreapp5.0' after >= or < in '>= netcoreapp5.0)) (&& (== netcoreapp2.0) (< netstandard1.1)) (&& (== netcoreapp2.0) (< netstandard2.0)) (&& (== netcoreapp2.0) (>= uap10.1)) (== netstandard2.0)'
	-  Could not parse 'framework: restriction: || (&& (== netcoreapp2.0) (>= netcoreapp5.0)) (&& (== netcoreapp2.0) (< netstandard1.1)) (&& (== netcoreapp2.0) (< netstandard2.0)) (&& (== netcoreapp2.0) (>= uap10.1)) (== netstandard2.0)' as key/value pairs.
	-> invalid delimiter at position 22

I've worked around this by rolling back paket to version 5.245.0, before support was added for netcoreapp5.0.

EDIT: I posted this on this issue as I suspect it is related to the rename.

@thinkbeforecoding
Copy link
Contributor

should net5.0 be parsed as a FrameworkVersion.V5 or a DotNetCoreAppVersion.V5_0, or something new ?

@forki
Copy link
Member

forki commented Aug 19, 2020 via email

@thinkbeforecoding
Copy link
Contributor

I created a PR for this #3899

@thinkbeforecoding
Copy link
Contributor

This seems to be working great with 6.0.0-alpha042 ! I think we can close this issue

@forki
Copy link
Member

forki commented Aug 19, 2020

Hurray

@forki forki closed this as completed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants