Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache name with prerelease truncated #424

Closed
ctaggart opened this issue Dec 4, 2014 · 4 comments · Fixed by #426
Closed

cache name with prerelease truncated #424

ctaggart opened this issue Dec 4, 2014 · 4 comments · Fixed by #426

Comments

@ctaggart
Copy link
Contributor

ctaggart commented Dec 4, 2014

This is happening on a couple different projects of mine, both using the same prerelease suffix scheme and both on AppVeyor. Paket is downloading files like SourceLink.SymbolStore.0.5.0-ci1411131947.nupkg and caching them as SourceLink.SymbolStore.0.5.0-ci.nupkg in %localappdata%\nuget\cache. Without the 1411131947 part of the suffix, the same file keeps getting extracted. The workaround is to clear packages and the cache.

@mexx
Copy link
Member

mexx commented Dec 5, 2014

The normalized version do not handle number part of prerelease identifiers. See NuGetV2.fs#L238 and SemVer.fs#L69.

@forki
Copy link
Member

forki commented Dec 5, 2014

Will try to reproduce
On Dec 5, 2014 7:43 AM, "Max Malook" notifications@github.com wrote:

The normalized version do not handle number part of prerelease
identifiers. See NuGetV2.fs#L238

let fi = FileInfo(Path.Combine(CacheFolder,sprintf "%s.%s.json" package (version.Normalize())))

and SemVer.fs#L69
| Some preRelease -> "-" + preRelease.Name + preReleaseBuild

.


Reply to this email directly or view it on GitHub
#424 (comment).

@forki
Copy link
Member

forki commented Dec 5, 2014

Ah didn't see @mexx already sent a pull request.

@forki forki closed this as completed in #426 Dec 5, 2014
forki added a commit that referenced this issue Dec 5, 2014
@ctaggart
Copy link
Contributor Author

ctaggart commented Dec 5, 2014

Thanks @mexx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants