Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paket.version file not generated (0.27.11) #600

Closed
cdrnet opened this issue Feb 13, 2015 · 7 comments
Closed

paket.version file not generated (0.27.11) #600

cdrnet opened this issue Feb 13, 2015 · 7 comments

Comments

@cdrnet
Copy link
Member

cdrnet commented Feb 13, 2015

The first run of build.sh of ProjectScaffold fails with

Paket failed with:
    Could not find file 'c:\ [...] \fsharp\FAKE\modules\Octokit\paket.version'.

Indeed, the file is not there. This seems to be a recent regression as it works fine in 0.27.10 but fails with 0.27.11.
@forki
Copy link
Member

forki commented Feb 13, 2015

Ok. Will look at this. /cc @sergey-tihon

@cdrnet
Copy link
Member Author

cdrnet commented Feb 13, 2015

Looks like here we should check whether the file exists, if not write it as before.

@forki
Copy link
Member

forki commented Feb 13, 2015

Could you please send a pull request?

@cdrnet
Copy link
Member Author

cdrnet commented Feb 13, 2015

Yes, will do.

cdrnet added a commit to cdrnet/Paket that referenced this issue Feb 13, 2015
@cdrnet
Fix for fsprojects#600 - paket.version file not generated
1ec50bb
@cdrnet cdrnet mentioned this issue Feb 13, 2015
Merged
forki added a commit that referenced this issue Feb 13, 2015
@forki
Merge pull request #601 from cdrnet/issue-600
f369b02 
Fix for #600 - paket.version file not generated
@forki forki closed this as completed Feb 13, 2015
@cdrnet
Copy link
Member Author

cdrnet commented Feb 13, 2015

Hm, that does not seem to have been enough, will check

@sergey-tihon
Copy link
Member

Ouch, sorry guys
Thank you @cdrnet

@cdrnet
Copy link
Member Author

cdrnet commented Feb 13, 2015

Argh, I missed the operator precedence ... will submit a new PR, sorry for the extra work

cdrnet added a commit to cdrnet/Paket that referenced this issue Feb 13, 2015
@cdrnet
Fix 2 for fsprojects#600 - paket.version file not generated
a7965a8
forki added a commit that referenced this issue Feb 13, 2015
@forki
Merge pull request #603 from cdrnet/issue-600-2
1936f12 
Fix 2 for #600 - paket.version file not generated
@cdrnet cdrnet mentioned this issue Feb 15, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cdrnet @forki @sergey-tihon