Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paket install not respecting content:none #854

Closed
theburningmonk opened this issue Jun 2, 2015 · 7 comments
Closed

paket install not respecting content:none #854

theburningmonk opened this issue Jun 2, 2015 · 7 comments
Labels

Comments

@theburningmonk
Copy link

I'm running paket 1.6.4.0 and I want to stop FsCheck.Nunit from bringing in the FsCheckAddin.fs content file.

My paket.dependencies looks like:

source https://nuget.org/api/v2

nuget AWSSDK
nuget DynamoDB.Sql
nuget FSharp.Core
nuget FSharp.Formatting
nuget FsCheck
nuget FsCheck.Nunit >= 0 content:none
...

paket restore respects this but if someone runs paket.install then the FsCheckAddin.fs file is brought back in as paket install doesn't seem to respect the content:none clause

@forki
Copy link
Member

forki commented Jun 2, 2015

Is this an open source project where I can reproduce?

@theburningmonk
Copy link
Author

not open source unfortunately, but it seems to happen consistently for me, or perhaps I'm using the wrong commands?

steps:

  • paket add nuget FsCheck.Nunit project XYZ
  • edit paket.dependencies to add >=0 content:none for FsCheck.Nunit
  • delete FsCheckAddin.fs file from project
  • paket install adds the file back in
  • close VS2012
  • delete FsCheck.Nunit folder in pakcages
  • reopen VS2012
  • paket restore (package restored, and file is not added)
  • paket install (adds file back in)

@forki forki added the bug label Jun 2, 2015
@forki
Copy link
Member

forki commented Jun 2, 2015

i can reproduce.

the issue is that install doesn't detect the content:none addition in the dependencies file therefor doesn't change the lock file.

if you run update once then this would be fixed (since it recomputes the lock file).

That said: I consider this a bug and try to fix it.

@theburningmonk
Copy link
Author

if I add another package it also seems to fix the issue too, thanks for looking into it

@forki
Copy link
Member

forki commented Jun 2, 2015

yeah. it all depends on the lockfile.

Just for clarification: Restore is not really important here since it will
never touch projects. it just downloads and extracts packages.

2015-06-02 16:01 GMT+02:00 Yan Cui notifications@github.com:

if I add another package it also seems to fix the issue too, thanks for
looking into it


Reply to this email directly or view it on GitHub
#854 (comment).

@forki forki closed this as completed in 5db33ab Jun 2, 2015
@forki
Copy link
Member

forki commented Jun 3, 2015

does it work for you?

@theburningmonk
Copy link
Author

yup, 1.10.0.0 does what I expect it to wrt to content:none thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants