-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom internet proxy credentials with env vars #1061
Conversation
/cc @vasily-kirichenko could you please take a look if this would still work for you? Thx |
Seems the tests fail on TravisCI / mono ;-) |
225c445
to
908e045
Compare
and could you please rebase the PR? thx |
Sorry, I'm on a vocation till 23/09. |
I will rebase the PR. |
Well problem disappeared after a couple of reinstallations and playing with alpha and beta mono channels. Not understood... No I can reproduce my bugs on mono. |
Env vars ARE case sensitive under mono environment. Should be fixed now (too late to wait for CI builds)... 💤 |
✌️ wow this was fast! |
Add support for custom internet proxy credentials with env vars
I guess we could need some docs for this. |
Sure! I guess you're talking about http://fsprojects.github.io/. |
A faq entry would be a good start. Please also tell something about the
|
OK will do :-) |
At work our internet proxy uses custom credentials (different from Active Directory standard credentials). E.g AD login is like sforkman150915 but proxy login is steffen.forkmann.
By default, Paket and bootstrapper set default credentials in IWebProxy. They fail with 407 if I want to use them. I've seen other strange behaviors like partial nuget conversion. I cannot use FsReveal for the same reasons (407!)
At work some of our tools use the following env vars: http_proxy, https_proxy and no_proxy (bypass list).
So I added support for these variables in Paket and bootstrapper.
I did it twice (once in C# for bootstrapper and once in F# for Paket Utils). I could not come with a pretty solution to factor this.
I tried to add as many tests as I could (did not test all the possibilities though)
Please review this commit. I'm not very fluent in F# yet.
I am wondering if env var are case sensitive in mono environment.
See also: https://msdn.microsoft.com/fr-fr/library/Hh272656.aspx
Next step: try to convince my team to ditch nuget...