-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow filtered updates of packages matching a regex #1178
Conversation
do you have a small sample for this? Then I could add a regression test |
Of course. Given dependency file:
Then:
Without the |
@@ -189,6 +189,7 @@ type Resolved = { | |||
type UpdateMode = | |||
| UpdatePackage of GroupName * PackageName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove that case and express it as UpdateFiltered of GroupName * PackageFilter
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in, escape .
s and treat it as a filter? I think it would work. Hope your regression tests are good up to date though! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give me a few minutes and I'll see if all the tests pass.
My code obviously rules :) |
Mind pushing that test to my master branch? I'll add it to the pull request. |
Ah, ok - I'll grab it. |
you need to run |
Should having working unit and integration tests now |
|> ignore) | ||
|> shouldFail | ||
|
||
[<Test>] | ||
let ``SelectiveUpdate does not update any package when package does not exist``() = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this test as it's expectation didn't seem meaningful anymore. With pattern based updates, a pattern that didn't match any packages should be a no-op, not an exception.
The update package command still checks that the specific named package exists before calling UpdateFiltered
Could also please write one or two samples in the docs of the update command? |
@forki crap. Push to wrong remote by mistake. Sorry. |
/me goes off to change default push repository |
no worries ;-) |
Especially useful for situations like "update all packages that start with my organisations prefix"