Unified cache implementation for V2 and V3 #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try | ||
| let cachedObject = JsonConvert.DeserializeObject<NugetPackageCache> json | ||
| Choice1Of2 cachedObject |
There was a problem hiding this comment.
just for sake of keeping the project uniform, can you please use the chessie types? Success and Fail IIRC
3 tasks
|
Updated to chessie types. |
forki
added a commit
that referenced
this pull request
Nov 13, 2015
Unified cache implementation for V2 and V3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work on #1212