Sets default resolver strategy for convert from nuget to None

integrationtests/Paket.IntegrationTests/ConvertFromNuGetSpecs.fs

@@ -9,6 +9,7 @@ open System.IO
 open System.Diagnostics
 open Paket
 open Paket.Domain
+open Paket.Requirements
 
 [<Test>]
 let ``#1217 should convert simple C# project``() = 
@@ -22,4 +23,31 @@ let ``#1217 should convert simple C# project``() =
     let depsFile = DependenciesFile.ReadFromFile(Path.Combine(scenarioTempPath "i001217-convert-simple-project","paket.dependencies"))
     let requirement = depsFile.GetGroup(Constants.MainDependencyGroup).Packages.Head
     requirement.Name |> shouldEqual (PackageName "Newtonsoft.Json")
-    requirement.VersionRequirement.ToString() |> shouldEqual "7.0.1"
+    requirement.VersionRequirement.ToString() |> shouldEqual "7.0.1"
+
+[<Test>]
+let ``#1225 should convert simple C# project with non-matching framework restrictions``() = 
+    paket "convert-from-nuget" "i001225-convert-simple-project-non-matching-restrictions" |> ignore
+    let lockFile = LockFile.LoadFrom(Path.Combine(scenarioTempPath "i001225-convert-simple-project-non-matching-restrictions","paket.lock"))
+    let v = lockFile.Groups.[Constants.MainDependencyGroup].Resolution.[PackageName "Newtonsoft.Json"].Version
+    v.Major |> shouldEqual 7u
+    v.Minor |> shouldEqual 0u
+    v.Patch |> shouldEqual 1u
+
+    let v2 = lockFile.Groups.[Constants.MainDependencyGroup].Resolution.[PackageName "Castle.Core"].Version
+    v2.Major |> shouldEqual 3u
+    v2.Minor |> shouldEqual 3u
+    v2.Patch |> shouldEqual 3u
+
+    let depsFile = DependenciesFile.ReadFromFile(Path.Combine(scenarioTempPath "i001225-convert-simple-project-non-matching-restrictions","paket.dependencies"))
+    let requirement = depsFile.GetGroup(Constants.MainDependencyGroup).Packages.Head
+    requirement.Name |> shouldEqual (PackageName "Castle.Core")
+    requirement.VersionRequirement.ToString() |> shouldEqual "3.3.3"
+    requirement.ResolverStrategy |> shouldEqual None
+    requirement.Settings.FrameworkRestrictions |> shouldEqual [FrameworkRestriction.AtLeast(FrameworkIdentifier.DotNetFramework(FrameworkVersion.V3_5))]
+
+    let requirement2 = depsFile.GetGroup(Constants.MainDependencyGroup).Packages.Tail.Head
+    requirement2.Name |> shouldEqual (PackageName "Newtonsoft.Json")
+    requirement2.VersionRequirement.ToString() |> shouldEqual "7.0.1"
+    requirement2.ResolverStrategy |> shouldEqual None
+    requirement2.Settings.FrameworkRestrictions |> shouldEqual [FrameworkRestriction.AtLeast(FrameworkIdentifier.DotNetFramework(FrameworkVersion.V4_Client))]

integrationtests/scenarios/i001225-convert-simple-project-non-matching-restrictions/before/ClassLibrary1/Class1.cs

@@ -0,0 +1,11 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+
+namespace ClassLibrary1
+{
+    public class Class1
+    {
+    }
+}

integrationtests/scenarios/i001225-convert-simple-project-non-matching-restrictions/before/ClassLibrary1/ClassLibrary1.csprojtemplate

@@ -0,0 +1,64 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
+  <PropertyGroup>
+    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
+    <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
+    <ProjectGuid>{0A4F4639-6C3A-4245-98FD-02E676CA9BD9}</ProjectGuid>
+    <OutputType>Library</OutputType>
+    <AppDesignerFolder>Properties</AppDesignerFolder>
+    <RootNamespace>ClassLibrary1</RootNamespace>
+    <AssemblyName>ClassLibrary1</AssemblyName>
+    <TargetFrameworkVersion>v4.0</TargetFrameworkVersion>
+    <FileAlignment>512</FileAlignment>
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
+    <DebugSymbols>true</DebugSymbols>
+    <DebugType>full</DebugType>
+    <Optimize>false</Optimize>
+    <OutputPath>bin\Debug\</OutputPath>
+    <DefineConstants>DEBUG;TRACE</DefineConstants>
+    <ErrorReport>prompt</ErrorReport>
+    <WarningLevel>4</WarningLevel>
+  </PropertyGroup>
+  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
+    <DebugType>pdbonly</DebugType>
+    <Optimize>true</Optimize>
+    <OutputPath>bin\Release\</OutputPath>
+    <DefineConstants>TRACE</DefineConstants>
+    <ErrorReport>prompt</ErrorReport>
+    <WarningLevel>4</WarningLevel>
+  </PropertyGroup>
+  <ItemGroup>
+    <Reference Include="Newtonsoft.Json, Version=7.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">
+      <HintPath>packages\Newtonsoft.Json.7.0.1\lib\net40\Newtonsoft.Json.dll</HintPath>
+      <Private>True</Private>
+    </Reference>
+    <Reference Include="Castle.Core, Version=3.3.0.0, Culture=neutral, PublicKeyToken=407dd0808d44fbdc, processorArchitecture=MSIL">
+      <HintPath>packages\Castle.Core.3.3.3\lib\net35\Castle.Core.dll</HintPath>
+      <Private>True</Private>
+    </Reference>
+    <Reference Include="System" />
+    <Reference Include="System.Core" />
+    <Reference Include="System.Xml.Linq" />
+    <Reference Include="System.Data.DataSetExtensions" />
+    <Reference Include="Microsoft.CSharp" />
+    <Reference Include="System.Data" />
+    <Reference Include="System.Xml" />
+  </ItemGroup>
+  <ItemGroup>
+    <Compile Include="Class1.cs" />
+    <Compile Include="Properties\AssemblyInfo.cs" />
+  </ItemGroup>
+  <ItemGroup>
+    <None Include="packages.config" />
+  </ItemGroup>
+  <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
+  <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
+       Other similar extension points exist, see Microsoft.Common.targets.
+  <Target Name="BeforeBuild">
+  </Target>
+  <Target Name="AfterBuild">
+  </Target>
+  -->
+</Project>

integrationtests/scenarios/i001225-convert-simple-project-non-matching-restrictions/before/ClassLibrary1/ClassLibrary1.sln

@@ -0,0 +1,22 @@
+
+Microsoft Visual Studio Solution File, Format Version 12.00
+# Visual Studio 2013
+VisualStudioVersion = 12.0.31101.0
+MinimumVisualStudioVersion = 10.0.40219.1
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ClassLibrary1", "ClassLibrary1.csproj", "{0A4F4639-6C3A-4245-98FD-02E676CA9BD9}"
+EndProject
+Global
+	GlobalSection(SolutionConfigurationPlatforms) = preSolution
+		Debug|Any CPU = Debug|Any CPU
+		Release|Any CPU = Release|Any CPU
+	EndGlobalSection
+	GlobalSection(ProjectConfigurationPlatforms) = postSolution
+		{0A4F4639-6C3A-4245-98FD-02E676CA9BD9}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{0A4F4639-6C3A-4245-98FD-02E676CA9BD9}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{0A4F4639-6C3A-4245-98FD-02E676CA9BD9}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{0A4F4639-6C3A-4245-98FD-02E676CA9BD9}.Release|Any CPU.Build.0 = Release|Any CPU
+	EndGlobalSection
+	GlobalSection(SolutionProperties) = preSolution
+		HideSolutionNode = FALSE
+	EndGlobalSection
+EndGlobal

integrationtests/scenarios/i001225-convert-simple-project-non-matching-restrictions/before/ClassLibrary1/Properties/AssemblyInfo.cs

@@ -0,0 +1,36 @@
+using System.Reflection;
+using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
+
+// General Information about an assembly is controlled through the following 
+// set of attributes. Change these attribute values to modify the information
+// associated with an assembly.
+[assembly: AssemblyTitle("ClassLibrary1")]
+[assembly: AssemblyDescription("")]
+[assembly: AssemblyConfiguration("")]
+[assembly: AssemblyCompany("")]
+[assembly: AssemblyProduct("ClassLibrary1")]
+[assembly: AssemblyCopyright("Copyright ©  2015")]
+[assembly: AssemblyTrademark("")]
+[assembly: AssemblyCulture("")]
+
+// Setting ComVisible to false makes the types in this assembly not visible 
+// to COM components.  If you need to access a type in this assembly from 
+// COM, set the ComVisible attribute to true on that type.
+[assembly: ComVisible(false)]
+
+// The following GUID is for the ID of the typelib if this project is exposed to COM
+[assembly: Guid("4aca4fc8-813d-4686-b15a-a6b4fbdd6f7d")]
+
+// Version information for an assembly consists of the following four values:
+//
+//      Major Version
+//      Minor Version 
+//      Build Number
+//      Revision
+//
+// You can specify all the values or you can default the Build and Revision Numbers 
+// by using the '*' as shown below:
+// [assembly: AssemblyVersion("1.0.*")]
+[assembly: AssemblyVersion("1.0.0.0")]
+[assembly: AssemblyFileVersion("1.0.0.0")]

integrationtests/scenarios/i001225-convert-simple-project-non-matching-restrictions/before/ClassLibrary1/packages.config

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="Newtonsoft.Json" version="7.0.1" targetFramework="net4" userInstalled="true" />
+  <package id="Castle.Core" version="3.3.3" targetFramework="net35" userInstalled="true" />
+</packages>

src/Paket.Core/NugetConvert.fs

@@ -214,7 +214,7 @@ let createPackageRequirement (packageName, version, restrictions) dependenciesFi
                 VersionRequirement(VersionRange.Minimum <| SemVer.Parse "0", PreReleaseStatus.No)
             else
                 VersionRequirement(VersionRange.Exactly version, PreReleaseStatus.No)
-       ResolverStrategy = Some ResolverStrategy.Max
+       ResolverStrategy = None
        Settings = { InstallSettings.Default with FrameworkRestrictions = restrictions }
        Parent = PackageRequirementSource.DependenciesFile dependenciesFileName
        Graph = [] }