Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix #2227] import .props/.targets better #2234

Merged
merged 2 commits into from
Apr 12, 2017
Merged

Conversation

0x53A
Copy link
Contributor

@0x53A 0x53A commented Apr 11, 2017

fixes #2227

  • differentiate between global targets/props, and framework specific targets/props
  • fw-specifc targets/props continue to be imported in the the middle with a condition (no change to before)
  • global props are imported at the top of the file (same as nuget does)
  • global targets are imported at the end of the file (same as nuget)

The reason is that many props depend on being imported at the top, so do that for the files where it is actually possible.

@0x53A 0x53A changed the title [Wip] import .props/.targets better [fix #2227] import .props/.targets better Apr 11, 2017
0x53A added 2 commits April 12, 2017 00:50
fixes fsprojects#2227

* differentiate between global targets/props, and framework specific targets/props
* fw-specifc targets/props continue to be imported in the the middle with a condition (no change to before)
* global props are imported at the top of the file (same as nuget does)
* global targets are imported at the end of the file (same as nuget)

The reason is that many props depend on being imported at the top, so do that for the files where it is actually possible.
@0x53A
Copy link
Contributor Author

0x53A commented Apr 11, 2017

Looks like travis is flakey? Close - reopen should trigger a rebuild ...

@0x53A 0x53A closed this Apr 11, 2017
@0x53A 0x53A reopened this Apr 11, 2017
@forki
Copy link
Member

forki commented Apr 12, 2017

Awesome! Let's see how it works in practice ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.props are imported too late
2 participants