Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add section about referencing branches other than master #249

Merged
merged 2 commits into from
Oct 12, 2014

Conversation

mexx
Copy link
Member

@mexx mexx commented Oct 12, 2014

No description provided.

@forki
Copy link
Member

forki commented Oct 12, 2014

that's actually not supported. since it would not look up the hash and won't pin in lock file.
But I'd love to see this happen

@ilkerde
Copy link
Contributor

ilkerde commented Oct 12, 2014

👍 Would be a great supportive thing to support floating sources. Imagine a source constraint a la FsUnit.fs (:master)...

@forki
Copy link
Member

forki commented Oct 12, 2014

actually I meant exactly the opposite.
At the moment it would be floating on the branch and that defeats the whole idea of the lockfile.

@mexx
Copy link
Member Author

mexx commented Oct 12, 2014

So you mean it's actually a bug in there, it's not locked currently, did I got you right?

@forki
Copy link
Member

forki commented Oct 12, 2014

Yes. It's a bug. Pinning only works on master.
On Oct 12, 2014 12:09 PM, "Max Malook" notifications@github.com wrote:

So you mean it's actually a bug in there, it's not locked currently, did I
got you right?


Reply to this email directly or view it on GitHub
#249 (comment).

@ilkerde
Copy link
Contributor

ilkerde commented Oct 12, 2014

OMG.

@forki
Copy link
Member

forki commented Oct 12, 2014

OMG? What do you mean?
On Oct 12, 2014 12:35 PM, "ilkerde" notifications@github.com wrote:

OMG.


Reply to this email directly or view it on GitHub
#249 (comment).

@ilkerde
Copy link
Contributor

ilkerde commented Oct 12, 2014

OMG = I didn't knew that we had this bug. I'm glad you have total control over this. I can hardly follow the state of development. Maybe that's why I missed this.

@forki
Copy link
Member

forki commented Oct 12, 2014

It's not really a bug. It's just not implemented.
On Oct 12, 2014 1:02 PM, "ilkerde" notifications@github.com wrote:

OMG = I didn't knew that we had this bug. I'm glad you have total control
over this. I can hardly follow the state of development. Maybe that's why I
missed this.


Reply to this email directly or view it on GitHub
#249 (comment).

@mexx mexx force-pushed the doc-github-dependencies branch from 6431f18 to c92cd76 Compare October 12, 2014 11:06
@mexx
Copy link
Member Author

mexx commented Oct 12, 2014

I've added the implementation for this.
It's working for me now.

@forki
Copy link
Member

forki commented Oct 12, 2014

So we can pin all branches?
On Oct 12, 2014 1:08 PM, "Max Malook" notifications@github.com wrote:

I've added the implementation for this.
It's working for me now.


Reply to this email directly or view it on GitHub
#249 (comment).

@mexx
Copy link
Member Author

mexx commented Oct 12, 2014

Yes with this code change we can.

@forki
Copy link
Member

forki commented Oct 12, 2014

Ha. Didn't see this trick. Kudos
On Oct 12, 2014 1:27 PM, "Max Malook" notifications@github.com wrote:

Yes with this code change we can.


Reply to this email directly or view it on GitHub
#249 (comment).

forki added a commit that referenced this pull request Oct 12, 2014
add section about referencing branches other than master
@forki forki merged commit 46db1f0 into fsprojects:master Oct 12, 2014
@mexx mexx deleted the doc-github-dependencies branch October 12, 2014 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants