Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply BindingRedirects much faster #414

Merged
merged 1 commit into from
Dec 4, 2014
Merged

Apply BindingRedirects much faster #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Paket.Core/BindingRedirects.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,8 @@ let private applyBindingRedirects bindingRedirects (configFilePath:string) =

/// Applies a set of binding redirects to all .config files in a specific folder.
let applyBindingRedirectsToFolder rootPath bindingRedirects =
let getFiles searchPattern = Directory.GetFiles(rootPath, searchPattern, SearchOption.AllDirectories) |> List.ofArray

getFiles "web.config" @
getFiles "app.config"
Directory.GetFiles(rootPath, "*.config", SearchOption.AllDirectories)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried EnumerateFiles instead of GetFiles? Could get more speed improvement.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not this time. The perf-improvement comes from the fact that we only scan once.

|> Seq.filter (fun x -> x.EndsWith "web.config" || x.EndsWith "app.config")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use EndsWith? searchPattern was without wildcard, shouldn't it be simply x = "web.config" || x = "app.config"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but It's the full path, right? Should be somethin like endwith DirectorySeparator + filename

|> Seq.iter (applyBindingRedirects bindingRedirects)

/// Calculates the short form of the public key token for use with binding redirects, if it exists.
Expand Down