WIP: Separate args for each command #551
Conversation
| | Some x -> x | ||
| | _ -> "" | ||
| match args with | ||
| | "add" :: args -> |
There was a problem hiding this comment.
why did we loose the nice discriminated union case here?
@mexx what do you think?
There was a problem hiding this comment.
Actually neither version looks good to me.
The old one do not support our use case for having separate argument for each command well.
The new one tries to provide the desired behavior but introduces redundancy and magic values.
I have to look further into Nessos.UnionArgParser to see how we can do better here.
I'll try to look at it on this weekend.
There was a problem hiding this comment.
Hm I'll see what I can do to bring the Commands DU back. @mexx what type of redundancy? You mean arguments that are applicable to more than one command?
|
Yes I think making the args more explicit per command is a good thing. |
theimowski
force-pushed
the
separate_args_for_each_command
branch
from
9e14d29 to
a7c5685
Compare
|
I added the Command DU - does it look any better now? |
|
|
||
| if results.IsUsageRequested then | ||
| trace <| results.Usage("paket config") |
There was a problem hiding this comment.
Why not showHelp HelpTexts.commands.["config"]?
There was a problem hiding this comment.
There's no "config" in this dictionary
There was a problem hiding this comment.
It was the actual implementation. Congratulations, you found a bug ;)
There was a problem hiding this comment.
Oh, indeed, didn't notice that one ;)
|
Looks a little bit better now. With this version of |
WIP: Separate args for each command
Because Paket.exe is always to be invoked with a given command, I thought it would be nice to separate arguments for each of the commands.
Tell me what you think, if you give green light I'll proceed with filling up the usages, and what else gives.