Target framework: Added >= and made warnings more clear #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @theimowski |
| @@ -184,7 +184,8 @@ module NugetEnv = | |||
| Packages = [for node in doc.SelectNodes("//package") -> | |||
| { Id = node.Attributes.["id"].Value | |||
| Version = node.Attributes.["version"].Value |> SemVer.Parse | |||
| TargetFramework = node |> getAttribute "targetFramework" } ]} | |||
| TargetFramework = | |||
| node |> getAttribute "targetFramework" |> Option.map (fun t -> ">= " + t) } ]} | |||
There was a problem hiding this comment.
so this is actually the only change necessary? i.e. we don't need to call the optimizeRestrictions function?
There was a problem hiding this comment.
Yes. I think the optimization happens later anyways. :-)
|
ready to merge? |
|
I guess there's this one thing that could be corrected, from my last code comment - everything else seems fine |
|
Fixed that, and some code clean-up also. |
|
❤️ |
forki
added a commit
that referenced
this pull request
Apr 10, 2015
Target framework: Added >= and made warnings more clear
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.