[WIP] Property tests for dependencies file parsing #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Reference Include="mscorlib" /> | ||
| <Reference Include="nunit.core"> |
There was a problem hiding this comment.
had to add those manually - FsCheck.Nunit package does that through powershell
There was a problem hiding this comment.
/cc @kurtschelfthout why is this in the powershell script?
There was a problem hiding this comment.
On mobile now so don't have a good overview, but think that's wrong, should be reference/content or whatever the canonical way of doing it is. Would you mind opening an issue?
forki
added a commit
that referenced
this pull request
May 3, 2015
|
ready to merge? |
|
Not yet, I'll do some improvements soon and let know when its ready |
|
OK I think it can be merged for now - added a bit more possibilities to the generator, however still there are some "hardcoded" values. |
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #802 the dependencies file caches all lines for later serializing, so this round-test may not be that useful, however it can surely serve as a safety net for future refactorings.
The test doesn't yet generate all valid dependencies files, but it could already find some pitfalls:
#,but can't have a hash-comment inline such as
nuget FsCheck #fscheck is coolDidn't fix those for now, instead made a workaround in generating test data