-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds PowerShell argument tab completion for Paket-Add #887
Conversation
fix fsproject/Paket#873 fix exception handling add some positional params
Last issue before this is mergable is that this is causing things to lock up. Paket-Add -NuGet |
This is good to go. |
Will fix later today, but needs time until the chocolatey people release it
|
In my blog, I'll talk about adding other chocolatey sources like the NuGet Gallery to stay up-to-date. choco source list
choco source add -n=nuget -s=https://www.nuget.org/api/v2 |
Nice. And I read they can also white-list tools. Maybe they will white-list
|
@@ -25,7 +25,10 @@ module PaketPs = | |||
async { | |||
try | |||
do! Async.SwitchToNewThread() | |||
do! computation | |||
try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the try with
here, an exception kills the started thread, which kills the powershell thread which kills powershell. It is important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add this as a comment in the code there.
if (-not $global:options) { $global:options = @{CustomArgumentCompleters = @{};NativeArgumentCompleters = @{}}} | ||
|
||
$global:options['CustomArgumentCompleters']['Paket-Add:NuGet'] = $findPackages | ||
$global:options['CustomArgumentCompleters']['Paket-Add:Version'] = $findPackageVersions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More argument tab completers can be added following this pattern. It must be done in PowerShell. The output of another command is used to do the tab completion.
adds PowerShell argument tab completion for Paket-Add
fix #873
fix exception handling
add some positional params
The list of versions should be sorted the other way. See #886.