Add number of items based record multiline formatter #1169
Conversation
Add associated types (Size; MultilineFormatterType) and isSmallExpression for choosing a formatter based on Size given.
…record-multiline
…number-of-items-record-multiline-formatter
|
@Fizzixnerd I'll review this thoroughly another time but I already want to point out that records have a broader scope. |
Thanks @nojaf. Yes, I am sort of winging it with what needs to be changed. I don't think I've ever explicitly used signature files or object expressions before, so it didn't occur to me they would be affected. I will write tests first for this project from now on, but if I'm not aware of everything that could be affected I'm afraid it won't be enough. Is there an issue/PR in the past that touched all aspects of records that I could use as a reference? I obviously don't want to miss anything else. |
Yeah, I know I'm asking more than you might need yourself but it is to remain consistent. You can write tests for signature files by using |
|
Great PR @Fizzixnerd! And thanks for reporting the inconsistencies you found along the way. |
|
No problem, thanks for fixing those nitpicks. |
See #1143.
I originally wrote the bulk of the code back when I was still calling it "LogicalSize". I have gone through the diffs looking to make sure I removed all references to that, but just be aware if I missed one that I'm not trying to sneak it in!
Currently the tests assume the current behaviour discussed in #1167. If that changes, then one of the tests here will need to change as well. I have affixed a
FIXMEto the test in question that can be removed when that issue is closed, but please let me know if you want it done a different way.