Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for cons pattern in let binding (#1996) #2891

Merged
merged 4 commits into from
Jun 2, 2023
Merged

Add regression test for cons pattern in let binding (#1996) #2891

merged 4 commits into from
Jun 2, 2023

Conversation

clkbug
Copy link
Contributor

@clkbug clkbug commented Jun 2, 2023

I wrote a regression test case for cons pattern in let binding (#1996).
Is it OK?

nojaf
nojaf approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for this PR!
There was something a little off in the test and I tweaked it slightly.

@nojaf nojaf linked an issue Jun 2, 2023 that may be closed by this pull request
Cons pattern in let bindings is converted to invalid code #1996
Closed
3 tasks
@nojaf nojaf enabled auto-merge (squash) June 2, 2023 09:40
@nojaf nojaf merged commit bfb4afc into fsprojects:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cons pattern in let bindings is converted to invalid code
2 participants
@clkbug @nojaf