Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some block comments in Rational #2949

Merged
merged 6 commits into from
Aug 29, 2023

Conversation

dawedawe
Copy link
Member

Fixes #2930
Fixes #2932
Fixes #2933

@dawedawe dawedawe force-pushed the fix_2930_2932_2933 branch from b6df903 to 6a544e6 Compare August 28, 2023 13:27
@dawedawe dawedawe marked this pull request as ready for review August 29, 2023 06:33
@dawedawe dawedawe requested a review from nojaf August 29, 2023 06:34
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one open question left.

src/Fantomas.Core/ASTTransformer.fs Outdated Show resolved Hide resolved
src/Fantomas.Core/ASTTransformer.fs Outdated Show resolved Hide resolved
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@dawedawe
Copy link
Member Author

Great work!

Thanks, especially for the help and discussion regarding the AST change.

@dawedawe dawedawe merged commit bb9c121 into fsprojects:main Aug 29, 2023
@dawedawe dawedawe deleted the fix_2930_2932_2933 branch August 29, 2023 07:11
@dawedawe dawedawe restored the fix_2930_2932_2933 branch August 29, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants