Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDK to 8.0.300 #3100

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Bump SDK to 8.0.300 #3100

merged 2 commits into from
Jul 9, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jul 9, 2024

No description provided.

@nojaf nojaf marked this pull request as ready for review July 9, 2024 06:37
@nojaf nojaf requested a review from dawedawe July 9, 2024 06:38
@Numpsy
Copy link

Numpsy commented Jul 9, 2024

Are the Failed to inline the value 'getLambdaBodyExpr' marked 'inline' warnings in the build a result of dotnet/fsharp#17161 or something else?

@nojaf
Copy link
Contributor Author

nojaf commented Jul 9, 2024

No clue, feel free to investigate.

@baronfel
Copy link
Contributor

baronfel commented Jul 9, 2024

It's a bug in the 300 release for F# - wait for this month's patch release and then go right to that one, by setting it as the min bar in your global.json.

@nojaf
Copy link
Contributor Author

nojaf commented Jul 9, 2024

As it is only a warning, I can temporary live with this.
Feel free to disagree @dawedawe, @josh-degraw.

Copy link
Member

@dawedawe dawedawe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I won't loose sleep about that temporary warning.

@nojaf nojaf merged commit 3e9c673 into fsprojects:main Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants