Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix idempotency for single case union w/o pipe #3116

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

joprice
Copy link
Contributor

@joprice joprice commented Sep 10, 2024

Fixes idempotency issue when a single-case union extension is not started with a pipe #3102. Without this change, the body of the extension body is moved one line downward on each format run.

Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

I tweaked it a bit as I didn't like the index access of the list.

@nojaf nojaf enabled auto-merge (squash) September 10, 2024 14:10
@nojaf nojaf merged commit ceb1fa2 into fsprojects:main Sep 10, 2024
5 checks passed
@joprice joprice deleted the unionIdempotency branch September 10, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants