Use a switch statement in validateVar, avoiding Array.prototype.indexOf

fstirlitz · Oct 20, 2019 · b74beab · b74beab
1 parent 382bebb
commit b74beab
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/luaparse.js b/luaparse.js
@@ -1978,7 +1978,12 @@
 
   function validateVar(node) {
     // @TODO we need something not dependent on the exact AST used. see also isCallExpression()
-    if (node.inParens || (['Identifier', 'MemberExpression', 'IndexExpression'].indexOf(node.type) === -1)) {
+    switch (node.inParens ? null : node.type) {
+    case 'Identifier':
+    case 'MemberExpression':
+    case 'IndexExpression':
+      return;
+    default:
       raise(token, errors.invalidVar, token.value);
     }
   }