Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid deprecated java.net.URL constructor #1166

Merged
merged 1 commit into from
Mar 25, 2023
Merged

avoid deprecated java.net.URL constructor #1166

merged 1 commit into from
Mar 25, 2023

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Mar 25, 2023

@mergify mergify bot added the core label Mar 25, 2023
@codecov
Copy link

codecov bot commented Mar 25, 2023 •
edited
Loading

Codecov Report

Merging #1166 (c2e361f) into master (d83b4e4) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #1166   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files          65       65           
  Lines         835      835           
  Branches       26       26           
=======================================
  Hits          774      774           
  Misses         61       61
Impacted Files Coverage Δ
...rc/main/scala/eu/timepit/refined/util/string.scala 0.00% <0.00%> (ø)
...rc/main/scala-3.0-/eu/timepit/refined/string.scala 98.76% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

fthomas
fthomas approved these changes Mar 25, 2023
View reviewed changes
Copy link
Owner

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @xuwei-k!

@fthomas fthomas merged commit cf28a14 into fthomas:master Mar 25, 2023
@xuwei-k xuwei-k deleted the java-net-URL-constructor branch March 25, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fthomas fthomas fthomas approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuwei-k @fthomas