Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target hop should be the largest hop per round not overall #1226

Closed
fujiapple852 opened this issue Jul 20, 2024 · 0 comments · Fixed by #1227
Closed

Target hop should be the largest hop per round not overall #1226

fujiapple852 opened this issue Jul 20, 2024 · 0 comments · Fixed by #1227
Labels
bug Something isn't working
Milestone
0.11.0

Comments

@fujiapple852
Copy link
Owner

Target hop should be determined from the maximum hop per round, not the maximum hop across rounds.
@fujiapple852 fujiapple852 added the bug Something isn't working label Jul 20, 2024
@fujiapple852 fujiapple852 added this to the 0.11.0 milestone Jul 20, 2024
@fujiapple852 fujiapple852 self-assigned this Jul 20, 2024
fujiapple852 added a commit that referenced this issue Jul 20, 2024
@fujiapple852
fix(core): calculate target hop from maximum hop per round (#1226)
fadf9f1
@fujiapple852 fujiapple852 mentioned this issue Jul 20, 2024
Merged
fujiapple852 added a commit that referenced this issue Jul 20, 2024
@fujiapple852
fix(core): calculate target hop from maximum hop per round (#1226)
7e808f7
@fujiapple852 fujiapple852 mentioned this issue Jul 20, 2024
Closed
fujiapple852 added a commit that referenced this issue Jul 21, 2024
@fujiapple852
fix(core): calculate target hop from maximum hop per round (#1226)
8a6f8c4
fujiapple852 added a commit that referenced this issue Jul 21, 2024
@fujiapple852
fix(core): calculate target hop from maximum hop per round (#1226)
bcde02b
fujiapple852 added a commit that referenced this issue Jul 21, 2024
@fujiapple852
doc: update CHANGELOG.md for #1226
6366eb5
@fujiapple852 fujiapple852 removed their assignment Jul 21, 2024
fujiapple852 added a commit that referenced this issue Jul 21, 2024
@fujiapple852
doc: update CHANGELOG.md for #1226
46665d3
@BrewTestBot BrewTestBot mentioned this issue Aug 11, 2024
Merged
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Aug 12, 2024
@0323pin
net/trippy: update to 0.11.0
b05e562 
[0.11.0] - 2024-08-11

Added

- Added NAT detection for `IPv4/udp/dublin` ([#1104](fujiapple852/trippy#1104))
- Added public API ([#1192](fujiapple852/trippy#1192))
- Added support for NAT detection (`N`) column ([#1219](fujiapple852/trippy#1219))
- Added support for last icmp packet type (`T`) column ([#1105](fujiapple852/trippy#1105))
- Added support for last icmp packet code (`C`) column ([#1109](fujiapple852/trippy#1109))
- Added support for the probe failure count (`f`) column ([#1258](fujiapple852/trippy#1258))
- Added settings dialog tab hotkeys ([#1217](fujiapple852/trippy#1217))
- Added `--dns-ttl` flag to allow refreshing the reverse DNS
  results ([#1233](fujiapple852/trippy#1233))
- Added `--generate-man` flag for generating [ROFF](https://en.wikipedia.org/wiki/Roff_(software)) man
  page ([#85](fujiapple852/trippy#85))
- Added Ubuntu PPA package ([#859](fujiapple852/trippy#859))
- Added Chocolatey package ([#572](fujiapple852/trippy#572))

Changed

- [BREAKING CHANGE] Changed initial sequence to be `33434` ([#1203](fujiapple852/trippy#1203))
- [BREAKING CHANGE] Renamed `tui-max-[samples|flows]`
  as `max-[samples|flows]` ([#1187](fujiapple852/trippy#1187))
- Separated library and binary crates ([#1141](fujiapple852/trippy#1141))
- Record `icmp` packet code ([#734](fujiapple852/trippy#734))
- Transient error handling for `IPv4` on macOS, Linux &
  Windows ([#1255](fujiapple852/trippy#1255))
- Improved error messages ([#1150](fujiapple852/trippy#1150))
- Revamp the help dialog ([#1260](fujiapple852/trippy#1260))

Fixed

- Fixed `DestinationUnreachable` incorrectly assumed to come from target
  host ([#1225](fujiapple852/trippy#1225))
- Fixed incorrect target hop calculation ([#1226](fujiapple852/trippy#1226))
- Do not conflate `AddressInUse` and `AddrNotAvailable`
  errors ([#1246](fujiapple852/trippy#1246))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

fix(core): calculate target hop from maximum hop per round (#1226) fujiapple852/trippy
1 participant
@fujiapple852