Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exclusive reference &mut for all Socket operations #843

Closed
fujiapple852 opened this issue Nov 29, 2023 · 0 comments · Fixed by #868
Closed

Use exclusive reference &mut for all Socket operations #843

fujiapple852 opened this issue Nov 29, 2023 · 0 comments · Fixed by #868
Labels
refactor
Milestone
0.10.0

Comments

@fujiapple852
Copy link
Owner

The Socket abstracts over an OS socket and is not thread safe. Many Socket operations mutate internal buffers. By using exclusive (&mut) references in all Socket operations we solve both of these issues.
@fujiapple852 fujiapple852 added this to the 0.10.0 milestone Nov 29, 2023
@fujiapple852 fujiapple852 mentioned this issue Nov 29, 2023
Closed
@fujiapple852 fujiapple852 self-assigned this Nov 29, 2023
fujiapple852 added a commit that referenced this issue Dec 15, 2023
@fujiapple852
refactor(net): use exclusive &mut for socket operations (#843)
ece7fc3
fujiapple852 added a commit that referenced this issue Dec 15, 2023
@fujiapple852
refactor(net): use exclusive &mut for socket operations (#843)
d33b9e4
@fujiapple852 fujiapple852 mentioned this issue Dec 15, 2023
Merged
fujiapple852 added a commit that referenced this issue Dec 15, 2023
@fujiapple852
refactor(net): use exclusive &mut for socket operations (#843)
3b01532
@fujiapple852 fujiapple852 removed their assignment Dec 15, 2023
@chenrui333 chenrui333 mentioned this issue Mar 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
0.10.0
1 participant
@fujiapple852