Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows port supporting ICMP, UDP and TCP over IPv4. IPv6 does not work (yet) #371

Closed
wants to merge 60 commits into from
Closed

Windows port supporting ICMP, UDP and TCP over IPv4. IPv6 does not work (yet) #371

wants to merge 60 commits into from

Conversation

zarkdav
Copy link
Collaborator

@zarkdav zarkdav commented Dec 15, 2022 •
edited by fujiapple852
Loading

Closes #98

zarkdav and others added 30 commits November 29, 2022 15:33
@zarkdav
Don't use Socket2 under Windows, rewrite discover_loca_addr as POC
3d6d4c8
@zarkdav
validate_local_addr & udp_socket_for_addr_family for Windows
301d4fa
@zarkdav
lookup_interface_addr for Windows
f3cb311
@zarkdav
ipaddr_to_sockaddr for Windows
195a908
@zarkdav
dispatch_icmp_probe (IPv4 only for now) for Windows
6937c96
@zarkdav
make_recv_socket (with overlapped support) for Windows
89b7deb
@zarkdav
prefer try_into().unwrap() when converting u32 to i32
b10ab2e
@zarkdav
rcv_icmp_probe, is_readable and ipv6::dispatch_icmp_probe for Windows
3afb1fc
@zarkdav
recv_icmp_probe fix match instead of if (boolean)
ca89554
@zarkdav
reenable main logic
84d8007
@fujiapple852
refactor: move TracerChannel creation inside the run_backend() fu…
2c6a7dd 
…nction
@zarkdav
Merge branch 'refactor-tracer-channel-config' of https://github.com/f…
07370ec 
…ujiapple852/trippy into windows-hacks2
@zarkdav
Windows Socket refactoring + ICMP logic fully implemented?
6c2a6c5
@zarkdav
Make clippy happy (and avoid passing around raw pointers)
a52a1f5
@zarkdav
Fix handling of WSARecvFrom WSA_IO_PENDING result
ae63e21
@zarkdav
Add create_event to Overlapped struct. Move WSAGetOverlappedResult in…
b999340 
…to is_readable
@zarkdav
Refactor wait_for_event, reset_event and get_overlapped_result in the…
e53dee8 
…ir respective struct
@zarkdav
Reuse icmp send socket for receive operations
7408ebc
@zarkdav
store OVERLAPPED and FROM on the heap with Box
6c04b30
@zarkdav
Store the WSABUF in a Box in order to avoid faulting, provide method …
e01e961 
…to get access to the buf as owned.
@zarkdav
Implement UDP for Windows
fb94b38
@zarkdav
set_ttl and set_tos for Windows
9248200
@zarkdav
Don't use Socket2 under Windows, rewrite discover_loca_addr as POC
03bf01c
@zarkdav
validate_local_addr & udp_socket_for_addr_family for Windows
3bad05b
@zarkdav
lookup_interface_addr for Windows
632d7e7
@zarkdav
ipaddr_to_sockaddr for Windows
6c6f34a
@zarkdav
dispatch_icmp_probe (IPv4 only for now) for Windows
f82429c
@zarkdav
make_recv_socket (with overlapped support) for Windows
01a6222
@zarkdav
prefer try_into().unwrap() when converting u32 to i32
c6afda7
@zarkdav
rcv_icmp_probe, is_readable and ipv6::dispatch_icmp_probe for Windows
e0e0b7b
@zarkdav
Implement UDP for Windows
8fa49d1
@zarkdav
set_ttl and set_tos for Windows
8868285
@zarkdav
Merge branch 'windows-hacks2' of github.com:zarkdav/trippy into windo…
16ec72a 
…ws-hacks2
@zarkdav
TCP for Windows
ae33128
@zarkdav
Use FD_ISSET instead of just the select result
e14df6e
@zarkdav
Use Overlapped selet on TCP stream socket configured to report ICMP e…
eb9190e 
…rrors
@zarkdav
Refactor setsockopt functions
5282d17
@zarkdav
Merge branch 'feat-tcp-lookup-by-sequence-id' of https://github.com/f…
db74196 
…ujiapple852/trippy into windows-hacks2
@zarkdav
Use Error::last_os_error().raw_os_error() instead of the unsafe WSAGe…
833f7ec 
…tLastError
@zarkdav
Manage TCP stream socket ICMP (v4) errors
43ed7ec
@zarkdav
Ipv6 TCP (untested)
c09a77d
@zarkdav
Merge branch 'master' into windows-hacks2
dee3fb4
@zarkdav
Add a couple of missing Windows specific conditional compilation attr…
c3425c8 
…ibutes
@fujiapple852 fujiapple852 added this to the 0.7.0 milestone Dec 15, 2022
@fujiapple852 fujiapple852 requested review from fujiapple852 and removed request for fujiapple852 December 15, 2022 14:53
@zarkdav zarkdav marked this pull request as draft December 15, 2022 14:57
@fujiapple852 fujiapple852 removed this from the 0.7.0 milestone Dec 16, 2022
@fujiapple852 fujiapple852 removed their request for review December 16, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zarkdav zarkdav

Labels
windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows support
2 participants
@zarkdav @fujiapple852