indexing.rst edits #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
fujiisoup
reviewed
Sep 11, 2017
doc/indexing.rst
Outdated
|
|
||
| .. note:: | ||
|
|
||
| + There should not be a conflict between the coordinates of indexer- and indexed- DataArrays. In v.0.10.0, xarray raises ``FutureWarning`` if there is such a conflict, but in the next major release, it will raise an Error. | ||
| - ``IndexError`` is raised if there is a conflict between dimension | ||
| coordinates of indexer- and indexed- DataArrays. |
There was a problem hiding this comment.
Should we raise IndexError for coordinate conflict?
The current code just neglects the conflicted coordinates.
There was a problem hiding this comment.
I think we do want to raise an error here, but as you note this is not the case currently. Let's discuss this over in the main issue (where I also just raised this concern)
There was a problem hiding this comment.
I removed this line for now. Let's add it back in later when we settle on how it should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.