Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm: Add AzureAD Auth #144

Merged
merged 2 commits into from
Nov 16, 2023
Merged

azurerm: Add AzureAD Auth #144

merged 2 commits into from
Nov 16, 2023

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Nov 11, 2023 •
edited
Loading

fixes #143

fujiwara
fujiwara reviewed Nov 14, 2023
View reviewed changes
Copy link
Owner

@fujiwara fujiwara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkroepke Thank you!
Added a comment for naming functions.

And I noticed names of functions for Azure should include "azure". I'll refactor that with another PR.

tfstate/remote_azurerm.go Outdated Show resolved Hide resolved
@jkroepke
getDefaultClient -> getDefaultAzureCredential
8f5a371 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@fujiwara fujiwara merged commit cbe77de into fujiwara:main Nov 16, 2023
2 checks passed
@fujiwara
Copy link
Owner

@jkroepke Thank you! I've confirmed works fine.

@fujiwara fujiwara mentioned this pull request Nov 16, 2023
Merged
@fujiwara
Copy link
Owner

v1.1.5 Released! https://github.com/fujiwara/tfstate-lookup/releases/tag/v1.1.5

@jkroepke jkroepke deleted the azurerm-add-auth branch November 16, 2023 07:05
@jkroepke jkroepke mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujiwara fujiwara Awaiting requested review from fujiwara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Azure - Support AAD Auth
2 participants
@jkroepke @fujiwara