Add tests for awesome mailto: links

[fulldecent]

Discussion

This is a not-awesome mailto link:

<a href="mailto:support@pacificmedicaltraining.com">Email us</a>

This is an awesome link:

<a href="mailto:support@pacificmedicaltraining.com?subject=Signing up&amp;body=Hello,\nI'd like to sign up for your course, can you please send me more information.">Email us</a>

We should use awesome links as psychological warfare against users. Users will send us emails with stupid or annoying emails that we don't want. So instead we prefill the email with the message we want to receive. It takes active cognitive effort for the user to put in their unwanted message.

You can make these with a tool like:

http://www.mailto.co.uk/

Actually that link does not work with /n, please recommend a better tool.

Also see http://stackoverflow.com/a/41365892/300224

Work plan

• Create extension for html-proofer that checks for awesome mailto links.
• I will publish it in a new repo.
• Integrate it into this project.

[ilyalyo]

@fulldecent this tool:
http://marcwitteveen.com/mailtogenerator/
can handle new lines.

[fulldecent]

Nice, that tool works great.

[ilyalyo]

@fulldecent just to clarify, it's not a PR to public html-proofer repository, it's going to be a private extension?

[fulldecent]

Yes, this is correct. We will follow the process here https://github.com/gjtorikian/html-proofer#custom-tests

I do not think html-proofer is interested to include that extension in its normal product.

We can do that work here

https://github.com/fulldecent/html-proofer-mailto-awesome

I suppose that you can set it up as a gem project. Then I will publish the gem to ruby gems. Then we will import it to https://github.com/fulldecent/lightning-sites in the test script.

[ilyalyo]

Added PR with extension: fulldecent/html-proofer-mailto_awesome#1
May be it would be better to make a fork?

[fulldecent]

I think the extension can be done more modularly. I have asked for help at gjtorikian/html-proofer#415

[fulldecent]

Please use this approach: https://github.com/gjtorikian/html-proofer#custom-tests

[ilyalyo]

This is have it's done now.
What do you think if we will make a fork and add all custom futures in it and use in our travis?

[fulldecent]

This should not be a fork. Here is the repository for this module:

https://github.com/fulldecent/html-proofer-mailto-awesome

We just want a simple class using the example in https://github.com/gjtorikian/html-proofer#custom-tests

Then I can publish as a gem. Then we can pull this gem from lightning-sites and call that custom class when we call html-proofer using Ruby.

[ilyalyo]

I pushed mailto-awesome class and gemspec into https://github.com/fulldecent/html-proofer-mailto-awesome

[fulldecent]

This looks good so far. Please update this file I started: https://github.com/fulldecent/html-proofer-mailto-awesome

[fulldecent]

OK, the https://github.com/fulldecent/html-proofer-mailto_awesome project is now published to ruby gems at https://rubygems.org/gems/html-proofer-mailto_awesome

Please use this gem from https://github.com/fulldecent/lightning-sites

[fulldecent]

Ready to use html-proofer-mailto_awesome from lightning-sites

[ilyalyo]

I updated mailto_awesom, so it can be run optionaly: added option check_mailto_awesome
fulldecent/html-proofer-mailto_awesome#8
and added this check to lighting sites:
fulldecent/lightning-sites#17

[fulldecent]

Fixed in fa757fe