Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amazing travis file that checks for all kinds of stuff #2

Closed
4 of 13 tasks
fulldecent opened this issue Jan 18, 2017 · 5 comments
Closed
4 of 13 tasks

Add amazing travis file that checks for all kinds of stuff #2

fulldecent opened this issue Jan 18, 2017 · 5 comments

Comments

@fulldecent
Copy link
Owner

fulldecent commented Jan 18, 2017

  • Update .travis.yml to call bundler exec rake test

Then add these things below into our lightning_sites.rb. Prefer to use the sh html-proofer ... approach rather than native ruby implementation, if it will save time!

Separate test_extensive task

  • Only check external links in this task

Tests that work on a served version of the site (i.e. php -S localhost:8000)

  • Make sure site redirects to HTTPS

Currently we use this for travis:

language: ruby
rvm:
- 2.2.5

script:
 - bundle exec jekyll build
 - bundle exec htmlproofer ./_site

env:
  global:
  - NOKOGIRI_USE_SYSTEM_LIBRARIES=true # speeds up installation of html-proofer

sudo: false # route your build to the container-based infrastructure for a faster build
@fulldecent
Copy link
Owner Author

Other low priority items:

  1. Do not duplicate META descriptions across pages
  2. Do not duplicate TITLE tags across pages
  3. Validate HTML source code is valid

Uncompressed images

  1. https://developers.google.com/speed/docs/insights/OptimizeImages
    As a result, optimizing images can often yield some of the largest byte savings and performance improvements: the fewer bytes the browser has to download, the less competition there is for the client's bandwidth and the faster the browser can download and render content on the screen.

@VirenMohindra
Copy link

VirenMohindra commented Feb 17, 2017

great stuff -- will definitely be watching this project.

Couldn't find the --timeframe flag in the htmlproofer docs and your usage helped fix my failing builds in travis CLI

Cheers

@fulldecent
Copy link
Owner Author

Thank you! FYI, here is more discussion about --timeframe and making it work with continuous integration. (Still an unsolved topic.)

gjtorikian/html-proofer#381

@fulldecent
Copy link
Owner Author

@VirenMohindra Thanks again, FYI, we are now 1.0.0

@fulldecent
Copy link
Owner Author

Broke this issue into individual items, closing.

#15, #16, #17, #18, #19, #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants