Merge pull request #16 from fulll/fix-signature-ttl-type-hint

Fix signature TTL type hint
fulll · Feb 28, 2023 · 112ceae · 112ceae
2 parents d5842c5 + 8ca314d
commit 112ceae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/Security/Firewall/RequestSignatureListener.php b/Security/Firewall/RequestSignatureListener.php
@@ -43,12 +43,14 @@ public function authenticate(Request $request): Passport
             throw new UnauthorizedHttpException('Signature must be filled.');
         }
 
+        $signatureTtlParameter = $this->signatureQueryParameters->getTimeQueryParameter();
+
         $signedRequest = new SignedRequest(
             $request->server->get('REQUEST_METHOD'),
             $request->server->get('HTTP_HOST'),
             $request->getPathInfo(),
             rawurldecode($request->getContent()),
-            $request->get($this->signatureQueryParameters->getTimeQueryParameter()),
+            $request->query->has($signatureTtlParameter) ? $request->query->getInt($signatureTtlParameter) : null,
         );
 
         try {

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -200,11 +200,6 @@ parameters:
 			count: 1
 			path: Security/Firewall/RequestSignatureListener.php
 
-		-
-			message: "#^Parameter \\#5 \\$signatureTime of class Rezzza\\\\SecurityBundle\\\\Security\\\\Firewall\\\\SignedRequest constructor expects int\\|null, mixed given\\.$#"
-			count: 1
-			path: Security/Firewall/RequestSignatureListener.php
-
 		-
 			message: "#^Property Rezzza\\\\SecurityBundle\\\\Security\\\\Firewall\\\\RequestSignatureListener\\:\\:\\$tokenStorage is never read, only written\\.$#"
 			count: 1