-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 비로그인 사용자도 리뷰 목록을 볼 수 있도록 수정 #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
로그인/비로그인 사용자 실패 테스트에서 다시 로그인/비로그인을 언급하는건 중복된 내용이므로 삭제함
명시하지 않을 경우 중복된 데이터를 가져옵니다
70825
commented
Apr 21, 2024
src/main/java/com/funeat/review/persistence/ReviewRepositoryImpl.java
Outdated
Show resolved
Hide resolved
Go-Jaecheol
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
설명이 잘 되어있어서 이해하기 편했네요 👍👍
논의해야 되는 부분에 대해서는 코멘트로 남겼는데, 51대 49 정도의 의견이라 로건 의견이랑 다른 사람들 의견 종합해서 정하면 될 것 같아요
src/main/java/com/funeat/review/persistence/ReviewRepositoryImpl.java
Outdated
Show resolved
Hide resolved
wugawuga
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
설명 차근차근 되어있어서 바로 파악하기에 너무 좋았습니다.
수고했어요오오~
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타
⏰ 일정