Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node.js 12 support, support Node.js 16 & 18 #18

Merged
merged 9 commits into from
Jun 6, 2023

Conversation

igoradamenko
Copy link
Contributor

No description provided.

@igoradamenko igoradamenko marked this pull request as ready for review June 6, 2023 11:32
},
"devDependencies": {
"@funboxteam/eslint-config": "7.1.0",
"ava": "3.15.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally I was not going to remove ava and nyc. But then after the linter config update I encountered an error, where eslint-import-plugin could not determine whether or not ava was installed.

I spent almost two hours diving into the dep chain, trying to understand what was going on. As a result I've figured out that the resolve package, used by that plugin to, well, resolve the deps, does not support ESM yet:

browserify/resolve#222

“Yet” is 3 years old for now, which probably means that it won't be supported ever.

Buuut, one might ask: “Why only the ava package is the problem here?”

“Good question,” I would answer! Because ava developers decided not to add a main field into their package.json. As they say, everything should work without that field. If it does not work, then it's your problem, not theirs:

avajs/ava#3128

Well, they have their right to develop the package as they want.

Same as we. So I removed ava completely and replaced it with Mocha.

@igoradamenko igoradamenko merged commit 832f27e into master Jun 6, 2023
@igoradamenko igoradamenko deleted the feature/node18 branch June 6, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant