Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Convertion from 3.x to 4.x #182

Closed
wants to merge 3 commits into from
Closed

DOC: Convertion from 3.x to 4.x #182

wants to merge 3 commits into from

Conversation

spirillen
Copy link
Contributor

Fixes spirillen/PyFunceble#30

Small Changes... became bigger rewrites

Have devided the docs/update/ into 4 files with 4 heading and reversed the listed order to

  • stable
  • dev
  • 4.x
  • 3.x

This way we follow the changelog cronology

requirements.doc.txt

  • Set forced version on sphinx to meet lexer for high ligthing code-block.

Fixes spirillen/PyFunceble#30

Small Changes... became bigger rewrites

Have devided the docs/update/ into 4 files with 4 heading and reversed the listed order to

  - stable
  - dev
  - 4.x
  - 3.x

This way we follow the changelog cronology

# requirements.doc.txt
  - Set forced version on sphinx to meet lexer for high ligthing code-block.
@coveralls
Copy link

coveralls commented Jan 9, 2021

Coverage Status

Coverage remained the same at 77.127% when pulling 531ff4b on spirillen:4.x-patch into 1cca8f1 on funilrys:dev.

Copy link
Owner

@funilrys funilrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, some little things and this will be good for merging! 😄

Thank you @spirillen!

docs/update/dev.rst Outdated Show resolved Hide resolved
docs/update/stable.rst Outdated Show resolved Hide resolved
docs/update/version-3.x.rst Outdated Show resolved Hide resolved
docs/update/version-4.x.rst Outdated Show resolved Hide resolved
Copy link
Owner

@funilrys funilrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you!

@funilrys
Copy link
Owner

I'm pretty sure I merged this 🤔

Closing.

@funilrys funilrys closed this Jan 10, 2021
@spirillen
Copy link
Contributor Author

I'm pretty sure I merged this thinking

Closing.

Approve and merge is two things 😝

@funilrys
Copy link
Owner

It is actually merged if you look at the history: https://github.com/funilrys/PyFunceble/commits/dev

@spirillen
Copy link
Contributor Author

That's weird.... approved + merged, but PR remains open as unmerged!!! can only be a Microsoft thing...

@funilrys
Copy link
Owner

Nope, it's me... I merged manually without the --no-ff argument I guess 😂

@spirillen
Copy link
Contributor Author

archhhhhh 😆

@spirillen spirillen deleted the 4.x-patch branch August 2, 2021 13:20
funilrys pushed a commit to PyFunceble/rst-docs that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants