Issue56fix

[creecros]

All Submissions:

• Have you updated the ChangeLog with your proposed changes?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• pr update to master branch
  • Have you updated the getPluginVersion() in Plugin.php and Makefile version appropriately?

New Feature Submissions:

• Have you added an explanation of what your changes do and why you'd like us to include them?

Description

Fixes #

• Fix "Undefined variable $not_editable" php warnings in kanboard wiki page #56
• Fix 'max_size' => get_upload_max_size(),

Changes proposed in this pull request:

• Change fixes bugs related to latest 0.3.2 version seen in "Undefined variable $not_editable" php warnings in kanboard wiki page #56. Also noticed attachments no longer work in 1.2.27 KB version, so fixed that as well.

[creecros]

related to:
kanboard/kanboard@b138a99

[creecros]

i didn't look into the why, but when sending $not_editable from the controller, i.e.

$this->response->html($this->helper->layout->app('wiki:wiki/show', array(
            'not_editable' => ($this->userSession->isLogged()) ? false : true,
            'project' => $project,
            'title' => $project['name'] .= " ". t('Wiki'),
            'wikipages' => $this->wiki->getWikipages($project['id']),
        ), 'wiki:wiki/sidebar'));

caused the top right drop downs to no longer function:

and the modals to also not function, i.e. edit wiki, or notification modal

instead, i put (isset($not_editable)) ?: $not_editable = false; into the template to simply check if it is set, and set to false if it is not.

[Webmasters-WPNGO]

In the end, what can you try to get the drop-down lists back to work?

[creecros]

@WebProviderNGO

it does work...

[Webmasters-WPNGO]

Thank you! There is no error, the dropdown list works!

ps Sorry, I forgot to undo previous changes

[creecros]

So it seems, a PR must have 1 reviewer, and I cannot review my own code.
@lastlink so only you can merge my commits.

which makes no sense, since anyone else can submit a PR and I can review it and merge it....There is a flaw in that system.

[prodrigoleao]

Thanks, work fine!

[creecros]

@lastlink can you give @alfredbuehler same roles as me, so we can approve our merge requests and get this plugin situated again?

[lastlink]

Can do

[lastlink]

@creecros done. I've pushed release 0.3.3 out with latest changes kanboard/website#510

[creecros]

@lastlink you are a true hero!