-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#6227: Make sure Series.unique()
with pyarrow dtype returns ArrowExtensionArray
#35
FIX-#6227: Make sure Series.unique()
with pyarrow dtype returns ArrowExtensionArray
#35
Conversation
…rowExtensionArray' Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Clone of the PR modin-project/modin#7042 |
My review is in progress 📖 - I will have feedback for you in a few minutes! |
Caution Review failedThe pull request is closed. WalkthroughThe changes enhance the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed your code and did not find any issues!
Please note that I can make mistakes, and you should still encourage your team to review your code as well.
/review |
PR Reviewer Guide 🔍
|
@coderabbitai review |
Actions performedReview triggered.
|
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-dateDescription by Korbit AI
Note
This feature is in early access. You can enable or disable it in the Korbit Console.
What change is being made?
Ensure
Series.unique()
with pyarrow dtype returnsArrowExtensionArray
by modifying the return statement and adding a corresponding test case.Why are these changes being made?
This change addresses issue #6227, where
Series.unique()
was not returning the expectedArrowExtensionArray
type when using pyarrow dtype. The modification ensures compatibility and correctness, and the added test case verifies the fix.Summary by CodeRabbit
New Features
unique
method inSeries
for better performance, directly returning unique values as a NumPy array.Tests
unique
method's behavior withuint8[pyarrow]
data type, ensuring consistency with Pandas outputs.