Feature/token balance #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiorRabin
previously approved these changes
May 4, 2020
| Future<dynamic> fetchTokenBalance(String accountAddress, {void Function(BigInt) onDone, Function onError}) async { | ||
| try { | ||
| final BigInt balance = await tokenAPI.getTokenBalanceByAccountAddress(this.address, accountAddress); | ||
| if (this.amount.compareTo(balance) != 0) { |
There was a problem hiding this comment.
what happens if this is false?
| bool isFetchTokensBalances = store.state.proWalletState?.isFetchTokensBalances ?? false; | ||
| if (!isFetchTokensBalances) { | ||
| UserState userState = store.state.userState; | ||
| new Timer.periodic(Duration(seconds: 3), (Timer timer) async { |
There was a problem hiding this comment.
maybe the interval should be in some config?
LiorRabin
approved these changes
May 4, 2020
LiorAgnin
added a commit
that referenced
this pull request
Jun 28, 2020
* Hotfix/analycis (#185) * analytics fixes and upgrade packages * bump v * update Community & Transfer Managers * update packages * bug fixes * added appname in IdentifyCall * fix * fixed remarks * Bump version to 1.1.20+141 * Bump version to 1.1.21+142 * login with device identifier (#186) * Bump version to 1.1.22+143 * add new identifier for existing users (#187) * identifier hotfix * Feature/pro mode (#188) * WIP * WIP * WIP * WIP * merged with maser * PRO MODE is ready * replaced icons * update podlock * fixed switch images * minor * fixed PR remarks * minor fix * Bump version to 1.1.23+144 * fixed (#190) * Bump version to 1.1.24+145 * fixed pro mode remarks (#191) * Bump version to 1.1.25+146 * Improve developer setup instructions in README (#194) I encountered the following exception when trying to run the flutter app in an Android device with `flutter run`: A problem occurred evaluating project ':app'. > path may not be null or empty string. path='null' It turns out I needed to create a flutter keystore and add a key.properties file to the project, as described here: https://flutter.dev/docs/deployment/android So I’ve updated the developer setup instructions in the README to make these extra steps clearer. * Update README.md * Update README.md * Delete .flutter-plugins-dependencies * Delete google-services1.json * Feature/pro mode final fixes (#199) * WIP * WIP * TABS is ready * initialRoute - last fixes * more fixes * more fixesss * bump * add dai is ready * new fixess * design qa fixess * added screens && pro mode events * added fake pending * minor * WIP * bump v * added more events for pro mode * WIP * WIP * WIP * bump * fix * fixs * bump v * bump * lazy load images * fix build * final fixed * added approve_job & indensia language * bump v * fixed language selector * bugs fixess * remove updateTheme * update I18n files * fixed timers * change udid plugin (#198) * Delete .flutter-plugins-dependencies Co-authored-by: Tal Beja <tal@fuse.io> * deps * deps * refresh token on start (#203) * refresh token on start * ref wallet_core * Feature/token balance (#204) * WIP * works! * added interval seconds variable to env * Bump version to 1.1.30+162 * switch community on push with data (#207) * switch community on push with data * refactor * change webview & add transak (#206) * change webview * back button on webview * Bump version to 1.1.32+164 * hebrew fix (#208) * hebrew fix * minor * sync backup with server (#205) * Feature/phone numbers (#210) * added app name to sentry * fixed red screen * added libphonenumber * code cleanup * send to phone number in another iso code * fix * minor * added number to review page * Bump version to 1.1.33+165 * some locks * fixed (#211) * fees added (#212) * fees added * cleanup * bump v * bump * bugs fixes - fee * removed unused variables * wrapperAddress removed * Bump version to 1.1.34+171 * Hotfix/fee (#213) * oops * update timestamp on update balance from etherscan * Bump version to 1.1.35+172 * oops (#214) * bump minor * fixed switch community * Hotfix/ui (#215) * fixess * pro token header bit higher * ui fixes * minor * fixed switch community * bump * added loader when clicking on contact (#219) * minor Co-authored-by: Tal Beja <tal@fuse.io> Co-authored-by: Leon Prouger <leonprou@gmail.com> Co-authored-by: Zarino Zappia <mail@zarino.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Refactor:
Feature:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply