Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests in all environments #15

Merged
merged 2 commits into from
Nov 15, 2017
Merged

Fix tests in all environments #15

merged 2 commits into from
Nov 15, 2017

Conversation

angus-c
Copy link
Contributor

@angus-c angus-c commented Nov 15, 2017 •
edited
Loading

Resolves #16

KevinGrandon
KevinGrandon approved these changes Nov 15, 2017
View reviewed changes
Copy link
Contributor

@KevinGrandon KevinGrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I guess sauce labs is also having trouble getting their hands on the iPhone X ;-)

@angus-c
Copy link
Contributor Author

angus-c commented Nov 15, 2017

@KevinGrandon yep not enough to go around—taking 7 minutes!

@angus-c angus-c merged commit 383e694 into master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganemone ganemone ganemone approved these changes

@KevinGrandon KevinGrandon KevinGrandon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angus-c @KevinGrandon @ganemone