Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Improve Flow coverage #112

Merged
merged 4 commits into from
May 11, 2018
Merged

Improve Flow coverage #112

merged 4 commits into from
May 11, 2018

Conversation

AlexMSmithCA
Copy link
Member

#### Problem/Rationale

Fusion.js packages, with the exception of `fusion-core` do not export [libdef](https://flow.org/en/docs/libdefs/) and consumers rely on the Flow type definitions embedded in the source code.  Given this, it is a pain point for consumers when type definitions are missing or incomplete.

We should also strive for full Flow coverage to minimize issues within our own packages.

#### Solution/Change/Deliverable

Two-fold:
* Reach 100% Flow coverage on exported type definitions.
* Strive for 100% Flow coverage internally for each package.

screen shot 2018-05-08 at 5 26 45 pm

(compare to before)

@AlexMSmithCA AlexMSmithCA self-assigned this May 9, 2018
@AlexMSmithCA AlexMSmithCA changed the title Improve flow coverage Improve Flow coverage May 9, 2018
@codecov
Copy link

codecov bot commented May 9, 2018

Codecov Report

Merging #112 into master will increase coverage by 4.51%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #112      +/-   ##
========================================
+ Coverage   81.48%    86%   +4.51%     
========================================
  Files           1      2       +1     
  Lines          27     50      +23     
  Branches       12     16       +4     
========================================
+ Hits           22     43      +21     
- Misses          4      6       +2     
  Partials        1      1
Impacted Files Coverage Δ
src/client.js 81.48% <100%> (ø) ⬆️
src/server.js 91.3% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 472ea30...668606a. Read the comment docs.

KevinGrandon
KevinGrandon previously approved these changes May 11, 2018
@AlexMSmithCA
Copy link
Member Author

!merge

@old-fusion-bot
Copy link

Failed to merge PR: At least 1 approving review is required by reviewers with write access.

@AlexMSmithCA AlexMSmithCA merged commit 7cac73a into fusionjs:master May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants