This repository has been archived by the owner on May 17, 2019. It is now read-only.
Fix opener access errors #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 86% 88.46% +2.46%
==========================================
Files 2 2
Lines 50 52 +2
Branches 16 16
==========================================
+ Hits 43 46 +3
+ Misses 6 5 -1
Partials 1 1
Continue to review full report at Codecov.
|
|
On Chrome 69, |
dennisgl
previously approved these changes
Jul 9, 2018
dennisgl
reviewed
Jul 9, 2018
src/__tests__/index.browser.js
Outdated
|
|
||
| app.register(ErrorHandlingPlugin); | ||
|
|
||
| getSimulator(app); |
There was a problem hiding this comment.
nit:
t.doesNotThrow(() => getSimulator(app));
|
@dennisgl thanks for the quick review. I've pushed a commit with the explicit exception check. |
dennisgl
approved these changes
Jul 10, 2018
|
!merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a page with this plugin is opened after clicking a link from an external domain, an error is thrown during app initialisation:
DOMException: Blocked a frame with origin "https://<my_domain>" from accessing a cross-origin frame.This is due to Chrome preventing any (even read) access to
window.openerin such cases.This PR provides a test case + fixes the issue by adding a try/catch around the event binding. I possibly could have gone with a known-blacklist but IMO this is a safe, future-proof approach.