This repository has been archived by the owner on May 17, 2019. It is now read-only.
Use end event rather than overwriting ctx.res.end #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 2, 2018 17:05
gergelyke
reviewed
Aug 29, 2018
src/server.js
Outdated
| handler(ctx.req, ctx.res, () => { | ||
| // $FlowFixMe | ||
| ctx.res.end = oldEnd; | ||
| res.on('end', listener); |
There was a problem hiding this comment.
looking at how this is implemented in express, shouldn't we also listen on finish? asking because of https://github.com/jshttp/on-finished/blob/master/index.js#L104?
or maybe we could start using the on-finished package?
KevinGrandon
previously approved these changes
Aug 30, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the logic for knowing when a response is sent. Also fixes a bug where express and koa-helmet clash with respect to ctx.req.secure.