Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently Bollard relies on serde_with for a couple of uses in the swagger crate. It specifies serde_with 3+ but 2+ actually works just fine, at least if
cargo build
is anything to go by. Reducing the minimum version would enable people to use Bollard who can't upgrade to a later version of serde_with / its transitive deps, e.g. serde itself.Test Plan
I've tried running
cargo test --all-features --workspace
from the root of the repo on main and I see that not all the tests pass, so I'm not quite sure how to fully test that this works as intended.