Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to upload report to custom S3 (minio) #1605

Closed
Vatson112 opened this issue Feb 16, 2023 · 1 comment · Fixed by #1930
Closed

Support to upload report to custom S3 (minio) #1605

Vatson112 opened this issue Feb 16, 2023 · 1 comment · Fixed by #1930
Assignees

Comments

@Vatson112
Copy link

Description

It will be nice to have oportunity to use custom s3 provider like Minio.

Minio is AWS S3 compatible, so we can use ordinary aws cli with it. For example:

aws --endpoint-url https://play.min.io:9000 s3 ls

Therefore I think it's possible to implement this without completely rewriting the current implementation.

Unfortunatly, I dont have any expirience with AWS and AWS-SDK to realise it by myself.

@MaineK00n
Copy link
Collaborator

This part of the implementation should work if you follow the minio documentation below.

vuls/reporter/s3.go

Lines 38 to 45 in 7044929

config := &aws.Config{
Region: aws.String(w.Region),
Credentials: credentials.NewChainCredentials([]credentials.Provider{
&credentials.EnvProvider{},
&credentials.SharedCredentialsProvider{Filename: "", Profile: w.Profile},
&ec2rolecreds.EC2RoleProvider{Client: ec2metadata.New(ses)},
}),
}

https://github.com/krishnasrinivas/cookbook/blob/master/docs/aws-sdk-for-go-with-minio.md

@MaineK00n MaineK00n self-assigned this Feb 19, 2023
This was linked to pull requests May 21, 2024
@MaineK00n MaineK00n removed a link to a pull request May 22, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants