-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): use aws-sdk-go-v2 #1922
Conversation
8c4cd3a
to
e49eb48
Compare
af24af3
to
fa4c559
Compare
} | ||
s, err := session.NewSession(config) | ||
cfg, err := awsConfig.LoadDefaultConfig(context.TODO(), optFns...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fa4c559
to
8f49be1
Compare
8f49be1
to
b9fa428
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Behavior changed slightly. When "profile" is specified in config.toml and "AWS_ACCESS_KEY_ID" and "AWS_SECRET_ACCESS_KEY" are specified in environment variables, Before: "AWS_ACCESS_KEY_ID" and "AWS_SECRET_ACCESS_KEY" are used For someone who is running vuls in such configurations, please watch out. |
What did you implement:
https://aws.github.io/aws-sdk-go-v2/docs/migrating/
Type of change
How Has This Been Tested?
vuls report -to-s3
envvar
$ AWS_ACCESS_KEY_ID=<AWS_ACCESS_KEY_ID> AWS_SECRET_ACCESS_KEY=<AWS_SECRET_ACCESS_KEY> vuls report -to-s3
credential files
EC2 IMDS
vuls saas
$ vuls saas
Checklist:
You don't have to satisfy all of the following.
make fmt
make test
Is this ready for review?: YES
Reference