Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report/email): add Critical to email summary #1565

Conversation

bprodoehl
Copy link
Contributor

This PR adds Criticals to the email summary.

Fixes #1564

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I've been trying to get set up to run the integration tests, but haven't been successful in running them yet. I can switch this to a WIP until I'm able to run the tests if you'd prefer.

Checklist:

You don't have to satisfy all of the following.

  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@MaineK00n MaineK00n changed the title Add criticals to email summary fix(report/email): add Critical to email summary Dec 6, 2022
@MaineK00n MaineK00n self-requested a review December 6, 2022 23:14
@kotakanbe kotakanbe merged commit 554ecc4 into future-architect:master Dec 20, 2022
@bprodoehl
Copy link
Contributor Author

0.22 looks good on my environment. Thanks for fixing up my PR and merging this!

@bprodoehl bprodoehl deleted the feature/bjp/add-critical-to-email-summary branch December 20, 2022 04:22
@kotakanbe
Copy link
Member

@bprodoehl

Thanks for confirming that it works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email summary doesn't include criticals
3 participants