feat(contrib/fvuls) Add commands to obtained CPE information of network devices by executing snmp2cpe and upload to Fvuls server #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix_scanner_version
sadayuki-matsuno
requested changes
Sep 19, 2023
contrib/future-vuls/pkg/cpe/cpe.go
Outdated
| ) | ||
|
|
||
| type createPseudoServerInput struct { | ||
| APIKey string `json:"api_key"` |
contrib/future-vuls/pkg/cpe/cpe.go
Outdated
| return cpeDetail.Server.ServerName, nil | ||
| } | ||
|
|
||
| func sentHTTPRequest(req *http.Request, token string, proxy string) ([]byte, error) { |
sadayuki-matsuno
previously requested changes
Sep 19, 2023
contrib/future-vuls/cmd/main.go
Outdated
Comment on lines
109
to
110
| fmt.Printf("%v", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
What is the reason for exiting without returning err?
contrib/future-vuls/cmd/main.go
Outdated
Comment on lines
135
to
136
| fmt.Printf("%v", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
What is the reason for exiting without returning err?
contrib/future-vuls/cmd/main.go
Outdated
Comment on lines
139
to
140
| fmt.Printf("%v", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
What is the reason for exiting without returning err?
refactor --------- Co-authored-by: 和田皓翔 <wadahiroka@192.168.0.6>
fix --------- Co-authored-by: Sadayuki Matsuno <sadayuki.matsuno@gmail.com> Co-authored-by: 和田皓翔 <wadahiroka@192.168.0.6>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
There are two commands.
future-vuls discover- Explore hosts within the CIDR range using the ping command
- Exec snmp2cpe(#1625) to active hosts to obtain CPE
Commands running internally
snmp2cpe v2c {IPAddr} public | snmp2cpe convert- Describe the information including CPE on the found hosts in a toml-formatted file.
Structure of toml-formatted file
- Default output file is discover_list.toml
- If the file already exists, append the newly found host to the toml-formatted file. Old files are renamed with a timestamp.
ex.) 20230912161058_discover_list.toml
future-vuls add-cpeUpload CPE information on the specified(FvulsSync is true and UUID is obtained) hosts to Fvuls
- Create pseudo server to Fvuls to obtain uuid and upload CPE to Fvuls
- Default output file is discover_list.toml
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
discover_list.toml
Checklist:
You don't have to satisfy all of the following.
make fmtmake testIs this ready for review?: YES
Reference