Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detect/oracle): handle ksplice advisories #2003

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Aug 10, 2024

If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.

What did you implement:

Previously, for Oracle's ksplice advisory, we only considered .ksplice1., but sometimes it was .ksplice2.. This PR makes the comparison for ksplice advisory more accurate.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

before

$ vuls report
docker (oracle8.10)
===================
Total: 14 (Critical:0 High:6 Medium:7 Low:1 ?:0)
14/14 Fixed, 0 poc, 0 exploits, cisa: 0, uscert: 0, jpcert: 0 alerts
235 installed

+----------------+------+--------+-----+-----------+---------+--------------------------------+
|     CVE-ID     | CVSS | ATTACK | POC |   ALERT   |  FIXED  |            PACKAGES            |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2016-10228 |  8.9 |        |     |           |   fixed | glibc, glibc-common,           |
|                |      |        |     |           |         | glibc-langpack-en              |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2019-25013 |  8.9 |        |     |           |   fixed | glibc, glibc-common,           |
|                |      |        |     |           |         | glibc-langpack-en              |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2019-9169  |  8.9 |        |     |           |   fixed | glibc, glibc-common,           |
|                |      |        |     |           |         | glibc-langpack-en              |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2020-27618 |  8.9 |        |     |           |   fixed | glibc, glibc-common,           |
|                |      |        |     |           |         | glibc-langpack-en              |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2021-3326  |  8.9 |        |     |           |   fixed | glibc, glibc-common,           |
|                |      |        |     |           |         | glibc-langpack-en              |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2021-40528 |  8.9 |        |     |           |   fixed | libgcrypt                      |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2021-20231 |  6.9 |        |     |           |   fixed | gnutls                         |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2021-20232 |  6.9 |        |     |           |   fixed | gnutls                         |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2021-33560 |  6.9 |        |     |           |   fixed | libgcrypt                      |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2021-3580  |  6.9 |        |     |           |   fixed | gnutls                         |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2024-0553  |  6.9 |        |     |           |   fixed | gnutls                         |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2024-28182 |  6.9 |        |     |           |   fixed | libnghttp2                     |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2024-28834 |  6.9 |        |     |           |   fixed | gnutls                         |
+----------------+------+--------+-----+-----------+---------+--------------------------------+
| CVE-2023-2953  |  3.9 |        |     |           |   fixed | openldap                       |
+----------------+------+--------+-----+-----------+---------+--------------------------------+

$ cat results/2024-08-09T11-53-49+0900/docker.json | jq '.packages.glibc'
{
  "name": "glibc",
  "version": "2.28",
  "release": "251.0.2.el8_10.2",
  "newVersion": "2.28",
  "newRelease": "251.0.2.el8_10.2",
  "arch": "x86_64",
  "repository": "",
  "modularitylabel": ""
}

$ cat results/2024-08-09T11-53-49+0900/docker.json | jq '.scannedCves."CVE-2016-10228".affectedPackages'
[
  {
    "name": "glibc",
    "fixedIn": "2:2.28-151.0.1.ksplice2.el8"
  },
  {
    "name": "glibc-common",
    "fixedIn": "2:2.28-151.0.1.ksplice2.el8"
  },
  {
    "name": "glibc-langpack-en",
    "fixedIn": "2:2.28-151.0.1.ksplice2.el8"
  }
]

after

$ vuls report
...
docker (oracle8.10)
===================
Total: 9 (Critical:0 High:1 Medium:7 Low:1 ?:0)
9/9 Fixed, 0 poc, 0 exploits, cisa: 0, uscert: 0, jpcert: 0 alerts
235 installed

+----------------+------+--------+-----+-----------+---------+------------+
|     CVE-ID     | CVSS | ATTACK | POC |   ALERT   |  FIXED  |  PACKAGES  |
+----------------+------+--------+-----+-----------+---------+------------+
| CVE-2021-40528 |  8.9 |        |     |           |   fixed | libgcrypt  |
+----------------+------+--------+-----+-----------+---------+------------+
| CVE-2021-20231 |  6.9 |        |     |           |   fixed | gnutls     |
+----------------+------+--------+-----+-----------+---------+------------+
| CVE-2021-20232 |  6.9 |        |     |           |   fixed | gnutls     |
+----------------+------+--------+-----+-----------+---------+------------+
| CVE-2021-33560 |  6.9 |        |     |           |   fixed | libgcrypt  |
+----------------+------+--------+-----+-----------+---------+------------+
| CVE-2021-3580  |  6.9 |        |     |           |   fixed | gnutls     |
+----------------+------+--------+-----+-----------+---------+------------+
| CVE-2024-0553  |  6.9 |        |     |           |   fixed | gnutls     |
+----------------+------+--------+-----+-----------+---------+------------+
| CVE-2024-28182 |  6.9 |        |     |           |   fixed | libnghttp2 |
+----------------+------+--------+-----+-----------+---------+------------+
| CVE-2024-28834 |  6.9 |        |     |           |   fixed | gnutls     |
+----------------+------+--------+-----+-----------+---------+------------+
| CVE-2023-2953  |  3.9 |        |     |           |   fixed | openldap   |
+----------------+------+--------+-----+-----------+---------+------------+

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Aug 10, 2024
@MaineK00n MaineK00n requested a review from shino August 10, 2024 06:06
Copy link
Collaborator

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised! 👍

@MaineK00n MaineK00n merged commit 6425193 into master Aug 13, 2024
7 checks passed
@MaineK00n MaineK00n deleted the MaineK00n/oracle branch August 13, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants