Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update go to 1.23 #2032

Merged
merged 1 commit into from
Sep 30, 2024
Merged

build: update go to 1.23 #2032

merged 1 commit into from
Sep 30, 2024

Conversation

shino
Copy link
Collaborator

@shino shino commented Sep 26, 2024

If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.

What did you implement:

  • update go to 1.23 (latest)
  • update golangci-lint to 1.61 (latest, to run on go 1.23)

To workaround the performance issue at launch time, this PR add replace directive of open-policy-agent/opa.
This should be remove in the future, I filed the issue for that #2036 .

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

CI and by hand

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO

Reference

@shino shino force-pushed the shino/go-1.23 branch 2 times, most recently from d3db7d4 to d27c49f Compare September 27, 2024 05:57
Also pin open-policy-agent/opa according to aquasecurity/trivy#7427
@MaineK00n MaineK00n merged commit 98cbe6e into master Sep 30, 2024
7 checks passed
@MaineK00n MaineK00n deleted the shino/go-1.23 branch September 30, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants