Pr option block cleanup #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Koen Zandberg <koen@bergzand.net>
Previously, boards with large flashpages (e.g., nrf52 with 4k) would overflow their stack as a riotboot_flashpage_t structure containing a FLASHPAGE_SIZE'ed buffer was allocated on stack.
This disables automatic use of the softdevice, which is currently not working correctly in tandem with riotboot.
- If the file name extension is larger than 64 bytes handling of the url will fail because of SOCK_URLPATH_MAXLEN.
- update README according to new use case
In particular: - add a table of contents - rework the prerequisites section - fix some inconsistencies
I kept this in suit/ as the change collides with @kb2ma's coap PR's... |
Oh, I did not know that. So what is the plan then? Wait for RIOT-OS#11002 to get merged? Push RIOT-OS#11002 merge? Are there other dependencies in suit code? |
|
Of course I would love to see progress toward merging RIOT-OS#11002 and the rest in the series, as shown in the last couple of comments on RIOT-OS#10732. I have time available at present for this work. |
|
@kb2ma great to hear that! I'll try to give it a review then!, I'll have to refresh my block-coap Knowledge before though. |
Closed
|
Closing in favor of #30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR cleans up some duplicated code. If changes are agreed I will open a PR on master for the first commit adding the block2 wrapper.
Testing procedure
Follow examples/suit_update/README.md everything still works.
Issues/PRs references