Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A small refactoring #50

Merged
merged 8 commits into from
Oct 26, 2018
Merged

A small refactoring #50

merged 8 commits into from
Oct 26, 2018

Conversation

RomanPodymov
Copy link
Contributor

Hello.
Thank you for this library, here I found a lot of interesting ideas and now I just made a small refactoring for it.

mkj-is
mkj-is reviewed Oct 15, 2018
View reviewed changes
Copy link
Contributor

@mkj-is mkj-is left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your increasing effort. 😉 What was the reason for these changes? No matter what I think this PR is mostly about personal preferences and does not improve much.

Can you tell the motivation behind it?

Sources/Errors/UIAlertController+Error.swift Outdated Show resolved Hide resolved
Sources/Errors/UIAlertController+Error.swift Outdated Show resolved Hide resolved
Sources/Extensions/UIViewController+Deselection.swift Outdated Show resolved Hide resolved
Sources/Protocols/Nibable.swift Show resolved Hide resolved
@RomanPodymov
Copy link
Contributor Author

Hello @mkj-is
I just read this code to get something new and found some places that can be refactored.

@mkj-is
Copy link
Contributor

mkj-is commented Oct 24, 2018

Hello, do you plan to fix this? Or should we close it?

@RomanPodymov
Copy link
Contributor Author

Hello @mkj-is
Currently I don't have access to my mac. I hope that today in the evening I will find something with macOS and I will fix it.

mkj-is
mkj-is approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@mkj-is mkj-is left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help!

@mkj-is mkj-is merged commit 2b9fc79 into futuredapp:master Oct 26, 2018
@RomanPodymov RomanPodymov deleted the refactoring branch January 5, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkj-is mkj-is mkj-is approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomanPodymov @mkj-is