Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes for RTL handling
these changes also fixed issue #729: v0.3 RTL paging doesn't work correctly in Firefox and mobile Safari
Detailed changes:
Content.js
Added direction parameter to columns function to determine direction based on overall direction of the book not depending on random rtl direction attribute attached to the body
Layout.js
Pass the direction parameter to content.columns function from the the format function
managers/continuous/index.js
handle rtf scrolling on erase function, this resolves jumping to next chapter in rtl instead of showing the remaining content.
managers/default/index.js
added code to detect RTL scroll type as firefox use negative scrolling, chrome use positive
fixes to both next and prev functions in rtl paging
fixed firefox jump to next chapter instead of turning to next page
packaging.js
added language check against rtl languages for better handling of book direction instead of counting only on the spine attributes “page-progression-direction”